styling cleanup and remove lingering focus state on homepage button#650
Open
interim17 wants to merge 2 commits intofeature/homepagefrom
Open
styling cleanup and remove lingering focus state on homepage button#650interim17 wants to merge 2 commits intofeature/homepagefrom
interim17 wants to merge 2 commits intofeature/homepagefrom
Conversation
interim17
requested review from
ShrimpCryptid and
toloudis
and removed request for
a team
Comment on lines
+1
to
+3
| .header-spacing { | ||
| margin-bottom: 16px; | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
If this class is being used in multiple places, can you define it once in a global stylesheet and import it wherever it's being used?
https://developer.mozilla.org/en-US/docs/Web/CSS/@import
ShrimpCryptid
approved these changes
Jul 10, 2025
Contributor
ShrimpCryptid
left a comment
ShrimpCryptid
left a comment
There was a problem hiding this comment.
Non-blocking comments!
Comment on lines
+18
to
+22
| <h3> | ||
| To get started with the{" "} | ||
| <Link to={VIEWER_PATHNAME}>Simularium Viewer</Link>, either | ||
| download example data or convert your own data. | ||
| </p> | ||
| </h3> |
Contributor
There was a problem hiding this comment.
Ideally use the h1 > h2 > h3 page layout hierarchy
Co-authored-by: Peyton Lee <peytonalee@gmail.com>
toloudis
approved these changes
Aug 27, 2025
Contributor
toloudis
left a comment
toloudis
left a comment
There was a problem hiding this comment.
I didn't test it or anything but the changes look reasonable. I generally agree with Peyton's comment about h1-h2-h3 but can't evaluate it for this specific case.
ShrimpCryptid
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time estimate or Size
small
Problem
A number of PRs have been merged into the
feature/homepagebranch, I'd love to bring it into main.This is a small set of tweaks on spacing. There is more that can proceed on implementing those designs, but we don't want to fix everything in the feature branch, this is a cleanup of some spacing, font sizing, and typos I noticed.